dariuszseweryn commented on code in PR #9741:
URL: https://github.com/apache/nifi/pull/9741#discussion_r1969404277
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/ConsumeKinesisStream.java:
##########
@@ -169,31 +170,31 @@ public class ConsumeKinesisStream extends
AbstractAwsAsyncProcessor<KinesisAsync
);
static final PropertyDescriptor KINESIS_STREAM_NAME = new
PropertyDescriptor.Builder()
- .name("kinesis-stream-name")
+ .name("Amazon Kinesis Stream Name")
.displayName("Amazon Kinesis Stream Name")
Review Comment:
True though the Javadoc says:
> Sets a unique id for the property. This field is optional and if not
specified the PropertyDescriptor's name will be used as the identifying
attribute. However, by supplying an id, the PropertyDescriptor's name can be
changed without causing problems. This is beneficial because it allows a User
Interface to represent the name differently.
Params: displayName – of the property
Returns: the builder
I assume though that we can always add `.displayName()` again in the future
if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
