scottyaslan commented on code in PR #9733: URL: https://github.com/apache/nifi/pull/9733#discussion_r1965660396
########## nifi-frontend/src/main/frontend/libs/shared/src/assets/themes/apache-nifi.scss: ########## Review Comment: I dont think we want to override this token. I believe you and I have discussed the styles for this datepicker a few times on previous PRs but in this case I think less customization of the date picker widget theme the easier it is to maintain. You are correct that previous to this PR the date picker had a strange blue green hue colorize background but that seems to have been a misconfiguration of the color hues in the theme palettes. That strange color doesn't seem to be used in any other widgets. Using the standard material design style here is more in line with how selection is displayed in other places in our app like context menu, row hover state in the all of the listing... so yea this is an intentional change here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
