lordgamez commented on code in PR #1920:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1920#discussion_r1963297288
##########
minifi-api/include/minifi-cpp/core/logging/Logger.h:
##########
@@ -124,7 +126,8 @@ class Logger {
if (!should_log(level)) {
return;
}
- log_string(level, stringify(std::move(fmt),
map_args(std::forward<Args>(args))...));
+ auto message = stringify(std::move(fmt),
map_args(std::forward<Args>(args))...);
+ log_string(level, message);
Review Comment:
In a previous iteration it was used in multiple functions, it was left this
way by mistake after it was changed, fixed in
https://github.com/apache/nifi-minifi-cpp/pull/1920/commits/37c777f93422e963bfe1e159d4f589107084a239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
