exceptionfactory commented on code in PR #9715:
URL: https://github.com/apache/nifi/pull/9715#discussion_r1953346495
##########
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/field/ObjectLocalDateTimeFieldConverter.java:
##########
@@ -85,13 +90,31 @@ public LocalDateTime convertField(final Object field, final
Optional<String> pat
return tryParseAsNumber(string, name);
}
}
+ case Object[] objectArray -> {
+ if (objectArray.length != INT96_TIMESTAMP_BYTES_LENGTH) {
Review Comment:
This is a generalized converter, so introducing Parquet-specific handling
does not look like the right approach. The implementation should be localized
to the ParquetReader.
##########
nifi-extension-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/ParquetReader.java:
##########
@@ -40,16 +47,37 @@
"The schema will come from the Parquet data itself.")
public class ParquetReader extends AbstractControllerService implements
RecordReaderFactory {
+ public static final PropertyDescriptor INT96_TIMESTAMP_FIELDS = new
PropertyDescriptor.Builder()
+ .name("INT96 timestamp fields")
Review Comment:
This property name does not follow standard conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
