briansolo1985 commented on code in PR #9628:
URL: https://github.com/apache/nifi/pull/9628#discussion_r1912428218
##########
minifi/minifi-toolkit/minifi-toolkit-assembly/README.md:
##########
@@ -48,7 +48,8 @@ After downloading the binary and extracting it, to run the
MiNiFi Toolkit Conver
java org.apache.nifi.minifi.toolkit.configuration.ConfigMain <command>
options
Valid commands include:
- transform-yml: Transforms legacy MiNiFi flow config YAML into MiNiFi
flow config JSON
+ - transform-nifi: Transform NiFi2 flow JSON format into MiNifi flow JSON
format
Review Comment:
Many thanks for updating the documentation!
##########
minifi/minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/json/TransformNifiCommandFactory.java:
##########
@@ -63,8 +65,11 @@ private int transformNifiToJson(String[] args) {
RegisteredFlowSnapshot registeredFlowSnapshot =
readNifiFlow(sourceNiFiJsonPath);
VersionedDataflow versionedDataflow = new VersionedDataflow();
versionedDataflow.setRootGroup(registeredFlowSnapshot.getFlowContents());
- versionedDataflow
- .setParameterContexts(new
ArrayList<>(registeredFlowSnapshot.getParameterContexts().values()));
+ versionedDataflow.setParameterContexts(new
ArrayList<>(registeredFlowSnapshot.getParameterContexts().values()));
+
+ ConfigSchema configSchema = new
ConfigSchema(Collections.emptyMap());
+
versionedDataflow.setMaxTimerDrivenThreadCount(configSchema.getCoreProperties().getMaxConcurrentThreads().intValue());
Review Comment:
This will always result in the DEFAULT_MAX_CONCURRENT_THREADS, what about
just simply reference it without instantiating ConfigSchema?
```
versionedDataflow.setMaxTimerDrivenThreadCount(CorePropertiesSchema.DEFAULT_MAX_CONCURRENT_THREADS);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
