exceptionfactory commented on code in PR #9575:
URL: https://github.com/apache/nifi/pull/9575#discussion_r1884049332


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardLabelDAO.java:
##########
@@ -99,7 +101,9 @@ public Label updateLabel(LabelDTO labelDTO) {
             label.setPosition(new Position(labelDTO.getPosition().getX(), 
labelDTO.getPosition().getY()));
         }
         if (labelDTO.getStyle() != null) {
-            label.setStyle(labelDTO.getStyle());
+            final Map<String, String> updatedStyles = new HashMap<String, 
String>(label.getStyle());

Review Comment:
   @pvillard31 minor detail, re-declaring the types is not needed:
   ```suggestion
               final Map<String, String> updatedStyles = new 
HashMap<>(label.getStyle());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to