[
https://issues.apache.org/jira/browse/NIFI-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830157#comment-15830157
]
ASF GitHub Bot commented on NIFI-3359:
--------------------------------------
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1428
Thanks for starting all this modularization @scottyaslan! This looks mostly
good but I have a couple comments.
In nf-canvas.js, the loading of the cluster summary has been moved to
before the canvas initialization. However, there is an important sequence of
requests in the canvas initialization that needs to happen before any other
requests. Specifically, the userXhr needs to complete successfully before any
other requests can be issued.
In jquery.nfeditor.js, the description of the options in the function
documentation was lost.
In jquery.propertytable.js, the check for isOnCanvas checks if the path is
`/nifi/`. Do we know for a fact that the context path will always end in a
forward? Just wanted to make sure we were covered if the path happens to be
`/nifi` (if thats even possible).
Thought, the application the formatting for the column definitions for our
tables have become inconsistent. Can we get these to be consistent throughout?
Thanks again!
> Modularize all of nifi-web-ui except canvas directory
> -----------------------------------------------------
>
> Key: NIFI-3359
> URL: https://issues.apache.org/jira/browse/NIFI-3359
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
> Reporter: Scott Aslan
> Assignee: Scott Aslan
>
> Need to modularize (re-package) UI components to promote maintainability and
> eventual reusability for UI extensions. Components are already conceptually
> modular however circular references exists which should not be allowed. Need
> to re-package functions to eliminate circular
> references.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
