Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1428
Thanks for starting all this modularization @scottyaslan! This looks mostly
good but I have a couple comments.
In nf-canvas.js, the loading of the cluster summary has been moved to
before the canvas initialization. However, there is an important sequence of
requests in the canvas initialization that needs to happen before any other
requests. Specifically, the userXhr needs to complete successfully before any
other requests can be issued.
In jquery.nfeditor.js, the description of the options in the function
documentation was lost.
In jquery.propertytable.js, the check for isOnCanvas checks if the path is
`/nifi/`. Do we know for a fact that the context path will always end in a
forward? Just wanted to make sure we were covered if the path happens to be
`/nifi` (if thats even possible).
Thought, the application the formatting for the column definitions for our
tables have become inconsistent. Can we get these to be consistent throughout?
Thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
