szaszm commented on code in PR #1840:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1840#discussion_r1838474140
##########
extensions/sql/tests/SQLTestPlan.h:
##########
@@ -75,15 +75,15 @@ class SQLTestPlan {
return flow_file;
}
- std::shared_ptr<core::Processor> getSQLProcessor() {
+ core::Processor* getSQLProcessor() {
return processor_;
}
void run(bool reschedule = false) {
if (reschedule) {
plan_->reset(reschedule);
}
- plan_->runProcessor(0); // run the one and only sql processor
+ plan_->runProcessor(static_cast<size_t>(0)); // run the one and only sql
processor
Review Comment:
why is this cast necessary?
##########
extensions/standard-processors/tests/unit/ProcessorTests.cpp:
##########
@@ -411,10 +411,9 @@ TEST_CASE("Test Find file", "[getfileCreate3]") {
TestController testController;
LogTestController::getInstance().setDebug<minifi::provenance::ProvenanceReporter>();
std::shared_ptr<TestPlan> plan = testController.createPlan();
- std::shared_ptr<core::Processor> processor = plan->addProcessor("GetFile",
"getfileCreate2");
- std::shared_ptr<core::Processor> processorReport =
std::make_shared<org::apache::nifi::minifi::core::reporting::SiteToSiteProvenanceReportingTask>(
- std::make_shared<org::apache::nifi::minifi::Configure>());
- plan->addProcessor(processorReport, "reporter",
core::Relationship("success", "description"), false);
+ auto processor = plan->addProcessor("GetFile", "getfileCreate2");
+ auto processorReport =
plan->addProcessor(std::make_unique<org::apache::nifi::minifi::core::reporting::SiteToSiteProvenanceReportingTask>(
+ std::make_shared<org::apache::nifi::minifi::Configure>()), "reporter",
core::Relationship("success", "description"), false);
Review Comment:
I'm not a fan of using the fully qualified names, unless we're in the root
namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
