fgerlits commented on code in PR #9429: URL: https://github.com/apache/nifi/pull/9429#discussion_r1809261537
########## nifi-framework-bundle/nifi-framework-extensions/nifi-py4j-framework-bundle/nifi-python-framework/src/test/python/framework/TestDownloadDependencies.py: ########## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import os +import re +import subprocess +import tempfile +import unittest + +from ExtensionManager import ExtensionManager +from nifiapi.__jvm__ import JvmHolder +import ProcessorInspection + +TEST_PROCESSOR_FILE = 'src/test/resources/python/framework/processor_with_dependencies/ProcessorWithDependencies.py' + +class FakeJvm: + def __init__(self): + self.java = FakeJava() + +class FakeJava: + def __init__(self): + self.util = FakeJavaUtil() + +class FakeJavaUtil: + def ArrayList(self): + return FakeArrayList([]) + +class FakeArrayList: + def __init__(self, my_list): + self.my_list = my_list + + def __len__(self): + return len(self.my_list) + + def __iter__(self): + return iter(self.my_list) + + def add(self, element): + self.my_list.append(element) + +def get_version(pip_list_lines, package_name): + for line in pip_list_lines: + match = re.fullmatch(f"{package_name} +([0-9.]+)", line) + if match: + return match[1] + return None + +class TestDownloadDependencies(unittest.TestCase): + def test_import_external_dependencies(self): + class_nodes = ProcessorInspection.get_processor_class_nodes(TEST_PROCESSOR_FILE) + self.assertIsNotNone(class_nodes) + self.assertEqual(len(class_nodes), 1) + class_node = class_nodes[0] + self.assertEqual(class_node.name, 'ProcessorWithDependencies') + + details = ProcessorInspection.get_processor_details(class_node, TEST_PROCESSOR_FILE, '/extensions/processor_with_dependencies', False) + self.assertIsNotNone(details) + + JvmHolder.jvm = FakeJvm() + extension_manager = ExtensionManager(None) + + with tempfile.TemporaryDirectory() as temp_dir: + packages_dir = os.path.join(temp_dir, 'packages') + extension_manager.import_external_dependencies(details, packages_dir) + + python_command = os.environ.get("PYTHON_CMD") + processor_packages_dir = os.path.join(packages_dir, 'extensions', 'ProcessorWithDependencies', '0.0.1') + pip_list_result = subprocess.run([python_command, '-m', 'pip', 'list', '--path', processor_packages_dir], capture_output=True) + self.assertEqual(pip_list_result.returncode, 0) + pip_list_lines = [line.decode() for line in pip_list_result.stdout.splitlines()] + + grpcio_version = get_version(pip_list_lines, 'grpcio') + self.assertIsNotNone(grpcio_version) + grpcio_status_version = get_version(pip_list_lines, 'grpcio-status') + self.assertEqual(grpcio_version, grpcio_status_version) Review Comment: The point of this test is that both packages depend on `grpcio`, but with different version bounds, so if we install one after the other, we'll end up with inconsistent versions. If I add a specific `grpcio` version to both places, then the old code will work, as well, so the test will no longer show what was fixed. Is it OK if I add a comment here in the test file with an explanation of why we are checking the `grpcio` versions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
