adamdebreceni commented on code in PR #1872:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1872#discussion_r1802535497
##########
libminifi/test/libtest/unit/TestBase.cpp:
##########
@@ -672,11 +672,20 @@ void TestPlan::validateAnnotations() const {
}
}
+std::vector<std::byte> TestPlan::getContentAsBytes(const core::FlowFile&
flow_file) const {
+ const auto content_claim = flow_file.getResourceClaim();
+ const auto content_stream = content_repo_->read(*content_claim);
+ const auto output_stream = std::make_shared<minifi::io::BufferStream>();
+ std::ignore = minifi::InputStreamPipe{*output_stream}(content_stream);
Review Comment:
despite its namespace `internal::pipe` is used in a number of places, so we
could use that here as well (I think we should "graduate" it out of the
internal namespace in the future)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
