lordgamez commented on code in PR #1875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1875#discussion_r1793625801
##########
libminifi/test/unit/LoggerTests.cpp:
##########
@@ -384,7 +384,7 @@ TEST_CASE("fmt formatting works with the logger") {
logger->log_critical("{} in hex is {:#x}", 13, 13);
logger->log_critical("Unix epoch: {}",
std::chrono::system_clock::time_point());
logger->log_critical("{:%Q %q} equals to {:%Q %q}", 2h,
std::chrono::duration_cast<std::chrono::seconds>(2h));
-
CHECK(LogTestController::getInstance().contains("[org::apache::nifi::minifi::core::logging::Logger]
[critical] 1m equals to 60s"));
+
CHECK(LogTestController::getInstance().contains("[org::apache::nifi::minifi::core::logging::Logger]
[critical] 1min equals to 60s"));
Review Comment:
Yes, this was needed when I updated the fmt library, the formatting of the
minute changed with the newer version. Conan was also using a newer version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
