exceptionfactory commented on code in PR #9290:
URL: https://github.com/apache/nifi/pull/9290#discussion_r1779176168
##########
nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelRecordReader.java:
##########
@@ -127,17 +134,6 @@ private Map<String, Object> getCurrentRowValues(Row
currentRow, boolean coerceTy
return currentRowValues;
}
- private static Object getCellValue(Cell cell) {
- if (cell != null) {
- return switch (cell.getCellType()) {
- case _NONE, BLANK, ERROR, FORMULA, STRING ->
cell.getStringCellValue();
- case NUMERIC -> DateUtil.isCellDateFormatted(cell) ?
cell.getDateCellValue() : cell.getNumericCellValue();
- case BOOLEAN -> cell.getBooleanCellValue();
Review Comment:
I think the strategy of using the `DataFormatter` in all cases is not great
because of the string localization. The `getNumericValue()` method seems like a
better option if that works consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
