exceptionfactory commented on code in PR #9304:
URL: https://github.com/apache/nifi/pull/9304#discussion_r1774132325
##########
nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/StandardServerConnectorFactory.java:
##########
@@ -68,6 +68,8 @@ public class StandardServerConnectorFactory implements
ServerConnectorFactory {
private String[] includeSecurityProtocols = INCLUDE_ALL_SECURITY_PROTOCOLS;
+ private int maxRequestHeaderSize = 8192;
Review Comment:
Recommend renaming this to `requestHeaderSize` to align with the Jetty
HttpConfiguration property name.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java:
##########
@@ -280,6 +280,13 @@ public class HandleHttpRequest extends AbstractProcessor {
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.NONE)
.build();
+ public static final PropertyDescriptor REQUEST_HEADERS_MAX_SIZE = new
PropertyDescriptor.Builder()
+ .name("HTTP Headers Maximum Size")
Review Comment:
Recommend dropping `HTTP` and adding `Request` since this is specific to
request headers and not response headers.
```suggestion
.name("Request Header Maximum Size")
```
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java:
##########
@@ -200,6 +200,13 @@ public AllowableValue getAllowableValue() {
.addValidator(StandardValidators.REGULAR_EXPRESSION_VALIDATOR)
.required(false)
.build();
+ public static final PropertyDescriptor REQUEST_HEADERS_MAX_SIZE = new
PropertyDescriptor.Builder()
+ .name("HTTP Headers Maximum Size")
Review Comment:
```suggestion
.name("Request Header Maximum Size")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
