mcgilman commented on code in PR #9214:
URL: https://github.com/apache/nifi/pull/9214#discussion_r1738911271
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##########
@@ -1126,6 +1126,24 @@ export class FlowEffects {
{ dispatch: false }
);
+ navigateToViewStatusHistoryForCurrentProcessGroup$ = createEffect(
+ () =>
+ this.actions$.pipe(
+
ofType(FlowActions.navigateToViewStatusHistoryForCurrentProcessGroup),
+ concatLatestFrom(() =>
this.store.select(selectCurrentProcessGroupId)),
+ tap(([, processGroupId]) => {
+ this.router.navigate([
+ '/process-groups',
+ processGroupId,
+ ComponentType.ProcessGroup,
+ processGroupId,
+ 'history'
+ ]);
Review Comment:
The assumption for this route is that the second id is a child component of
the Process Group specified by first id. I think adding a route for
`/process-groups/{id}/history` would be more correct for opening the status
history for the current Process Group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
