[
https://issues.apache.org/jira/browse/NIFI-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817474#comment-15817474
]
ASF GitHub Bot commented on NIFI-3214:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1410
NIFI-3214: Added fetch and replace to DistributedMapCache
There's no Processor that utilizes these new cache operations yet, but will
be added by [JIRA-3216](https://issues.apache.org/jira/browse/NIFI-3216). To
test client and server communication, please use
`org.apache.nifi.distributed.cache.server.TestServerAndClient` test class in
`nifi-distributed-cache-server` project. If you need to test it on Mac OS X,
then you also have to comment out these lines. Sometime it fails due to JVM
issue but sometime it works:
```
Assume.assumeFalse("test is skipped due to build environment being OS X
with JDK 1.8. See https://issues.apache.org/jira/browse/NIFI-437";,
SystemUtils.IS_OS_MAC && SystemUtils.IS_JAVA_1_8);
```
- Using fetch and replace together can provide optimistic locking for
concurrency control.
- Added fetch to get cache entry with its meta data such as revision number.
- Added replace to update cache only if it has not been updated.
- Added Map Cache protocol version 2 for those new operations.
- Existing operations such as get or put can work with protocol version 1.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [x] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-3214
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1410.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1410
----
commit b45b261e87be3035473673d303bbf14c0ccb35db
Author: Koji Kawamura <[email protected]>
Date: 2017-01-11T06:57:40Z
NIFI-3214: Added fetch and replace to DistributedMapCache
- Using fetch and replace together can provide optimistic locking for
concurrency control.
- Added fetch to get cache entry with its meta data such as revision
number.
- Added replace to update cache only if it has not been updated.
- Added Map Cache protocol version 2 for those new operations.
- Existing operations such as get or put can work with protocol version
1.
----
> Add a method to DistributedMapCacheClient to replace existing key only if it
> hasn't been changed
> ------------------------------------------------------------------------------------------------
>
> Key: NIFI-3214
> URL: https://issues.apache.org/jira/browse/NIFI-3214
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Bryan Bende
> Assignee: Koji Kawamura
>
> It would be helpful for some processors to be able to -get a list of all the
> keys in the distributed map cache that match some pattern, or even to get a
> list of all the keys. We should update DistributedMapCacheClient to have a
> method like getKeys(String pattern).- replace an existing key in the
> distributed map cache with concurrency control so that the key will be
> replaced only if it hasn't been updated by other operations since updating
> client program fetched the key.
> Updated JIRA description as mentioned in
> [NIFI-3216|https://issues.apache.org/jira/browse/NIFI-3216?focusedCommentId=15812535&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15812535].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
