mcgilman commented on code in PR #8965:
URL: https://github.com/apache/nifi/pull/8965#discussion_r1663183873


##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/state/controller-services/controller-services.effects.ts:
##########
@@ -635,6 +636,82 @@ export class ControllerServicesEffects {
         { dispatch: false }
     );
 
+    openMoveControllerServiceDialog$ = createEffect(
+        () =>
+            this.actions$.pipe(
+                
ofType(ControllerServicesActions.openMoveControllerServiceDialog),
+                map((action) => action.request),
+                concatLatestFrom(() => 
this.store.select(selectCurrentProcessGroupId)),
+                tap(([request, currentProcessGroupId]) => {
+                    const serviceId: string = request.id;
+                    request.processGroupFlow = 
this.flowService.getFlow(currentProcessGroupId);
+                    const moveDialogReference = 
this.dialog.open(MoveControllerService, {
+                        ...XL_DIALOG,

Review Comment:
   The dialog size looks great. Can we update it so the content shares the 
available space like other dialogs (for instance Edit Controller Service)?
   
   ![Screenshot 2024-07-02 at 5 18 11 
PM](https://github.com/apache/nifi/assets/123395/1bf341cd-ad19-4dea-8955-e5eeecadfafd)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to