Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/68#discussion_r93529520
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java
---
@@ -1197,7 +1197,14 @@ public void start() throws IOException,
InterruptedException {
this.changeListener = new MiNiFiConfigurationChangeListener(this,
defaultLogger);
this.periodicStatusReporters = initializePeriodicNotifiers();
startPeriodicNotifiers();
- this.changeCoordinator = initializeNotifier(this.changeListener);
+ try {
+ this.changeCoordinator =
initializeNotifier(this.changeListener);
+ } catch (Exception e) {
--- End diff --
I don't like how this catches any error and swallows the stack trace. Yes
in this instance we know what is wrong but we may not in other cases. I'd
prefer a more fine-grain catch block here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
