exceptionfactory commented on code in PR #6159:
URL: https://github.com/apache/nifi/pull/6159#discussion_r943459062
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureDataLakeStorage.java:
##########
@@ -83,11 +88,23 @@ public class PutAzureDataLakeStorage extends
AbstractAzureDataLakeStorageProcess
.allowableValues(FAIL_RESOLUTION, REPLACE_RESOLUTION,
IGNORE_RESOLUTION)
.build();
+ public static final PropertyDescriptor BASE_TEMPORARY_PATH = new
PropertyDescriptor.Builder()
+ .name("base-temporary-path")
+ .displayName("Base Temporary Path")
+ .description("The Path where the temporary directory will be
created. The Path name cannot contain a leading '/'." +
+ " The root directory can be designated by the empty string
value. Non-existing directories will be created." +
+ "The Temporary File Directory name is " +
TEMP_FILE_DIRECTORY)
+ .defaultValue("")
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .addValidator(new DirectoryValidator("Temp File Directory"))
Review Comment:
Should this label be adjusted to match the property name?
```suggestion
.addValidator(new DirectoryValidator("Base Temporary Path"))
```
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureDataLakeStorage.java:
##########
@@ -129,13 +130,23 @@ public class ListAzureDataLakeStorage extends
AbstractListAzureProcessor<ADLSFil
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
+ public static final PropertyDescriptor INCLUDE_TEMPORARY_FILES = new
PropertyDescriptor.Builder()
+ .name("include-temporary-files")
+ .displayName("include temporary files")
Review Comment:
Display Names should be capitalized:
```suggestion
.displayName("Include Temporary Files")
```
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/AbstractAzureDataLakeStorageProcessor.java:
##########
@@ -101,6 +101,8 @@ public abstract class AbstractAzureDataLakeStorageProcessor
extends AbstractProc
REL_FAILURE
)));
+ public static final String TEMP_FILE_DIRECTORY = "_$azuretempdirectory$";
Review Comment:
Thanks for the reply and reference to the previous discussion. Using
`_nifitempdirectory` sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
