[
https://issues.apache.org/jira/browse/NIFI-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15660756#comment-15660756
]
ASF GitHub Bot commented on NIFI-2866:
--------------------------------------
GitHub user combineads opened a pull request:
https://github.com/apache/nifi/pull/1212
NIFI-2866: The Initial Max Value of QueryDatabaseTable won't be case
I merged the commit logs.
Thank you for your review. @mattyb149
Original issue: #1101
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/combineads/nifi NIFI-2866
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1212.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1212
----
commit fc163bbe7f6e0ead9be8d8084f0f5a223a1406f8
Author: Byunghwa Yun <[email protected]>
Date: 2016-11-13T03:21:14Z
NIFI-2866 The Initial Max Value of QueryDatabaseTable won't be case
----
> The Initial Max Value of QueryDatabaseTable won't be case sensitive.
> --------------------------------------------------------------------
>
> Key: NIFI-2866
> URL: https://issues.apache.org/jira/browse/NIFI-2866
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.1.0
> Reporter: Byunghwa Yun
> Priority: Minor
>
> Now, the Initial Max Value of QueryDatabaseTable is allowed the only
> lowercase so I think to change the below code, it added .toLowerCase() method.
> for(final Map.Entry<String,String> maxProp :
> maxValueProperties.entrySet()){
> if
> (!statePropertyMap.containsKey(maxProp.getKey().toLowerCase())) {
> statePropertyMap.put(maxProp.getKey().toLowerCase(),
> maxProp.getValue());
> }
> }
> When I set the property that is initial.maxvalue.UPDATE_TIME,
> QueryDatabaseTable doesn't have WHERE clause with UPDATE_TIME.
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
