adam-markovics commented on PR #1381:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1381#issuecomment-1206203563
> Not strictly related, but there is a Clang Tidy check failure in
`ListenHTTPTests.cpp`, line 183:
>
> ```
>
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/civetweb/tests/ListenHTTPTests.cpp:183:15:
> error: the 'empty' method should be used to check for emptiness instead of
comparing to an empty object
[readability-container-size-empty,-warnings-as-errors]
> REQUIRE("" == response_body);
> ^~~~~~~~~~~~~~~~~~~
> response_body.empty()
> ```
>
> I think this small fix could be included in this PR. Either changing the
check to `.empty()` or adding a `NOLINT` comment would be fine.
Good Idea. I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
