szaszm commented on code in PR #1038:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1038#discussion_r925748724
##########
libminifi/src/core/yaml/YamlConnectionParser.cpp:
##########
@@ -97,7 +97,21 @@ uint64_t
YamlConnectionParser::getWorkQueueDataSizeFromYaml() const {
logger_->log_debug("Setting %" PRIu64 "as the max as the max queue data
size.", max_work_queue_data_size);
return max_work_queue_data_size;
}
- logger_->log_info("Invalid max queue data size value: %s.",
max_work_queue_str);
+ logger_->log_error("Invalid max queue data size value: %s.",
max_work_queue_str);
+ }
+ return 0;
+}
+
+uint64_t YamlConnectionParser::getSwapThresholdFromYaml() const {
+ const YAML::Node swap_threshold_node = connectionNode_["swap threshold"];
+ if (swap_threshold_node) {
+ auto swap_threshold_str = swap_threshold_node.as<std::string>();
+ uint64_t swap_threshold;
+ if (core::Property::StringToInt(swap_threshold_str, swap_threshold)) {
+ logger_->log_debug("Setting %" PRIu64 " as the swap threshold.",
swap_threshold);
+ return swap_threshold;
+ }
+ logger_->log_error("Invalid swap threshold value: %s.",
swap_threshold_str);
Review Comment:
created a separate jira issue for that:
https://issues.apache.org/jira/browse/MINIFICPP-1887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
