exceptionfactory opened a new pull request #5589:
URL: https://github.com/apache/nifi/pull/5589
#### Description of PR
NIFI-9457 Updates String to Timestamp conversion in `PutKudu` to support
optional fractional seconds with up to microsecond resolution.
The Kudu `UNIXTIME_MICROS` type uses `java.sql.Timestamp` objects with up to
microsecond precision, but the `DataTypeUtils.toTimestamp()` method does not
support microsecond resolution due to the internal use of
`java.text.SimpleDateFormat` for parsing Strings to `java.util.Date` objects
prior to conversion to `java.sql.Timestamp`.
The solution includes a new `ObjectTimestampFieldConverter` class with
generalized support for converting objects of various types to
`java.sql.Timestamp`. The converter follows a similar approach to
`DataTypeUtils.toTimestamp()` but uses `java.time.format.DateTimeFormatter` and
`java.time.LocalDateTime` for parsing Strings. This approach is not yet
suitable for generalized use, but it works for `PutKudu` since the conversion
in `buildPartialRow` does not support user-provided format patterns.
Using the custom timestamp pattern for Record `TIMESTAMP` fields together
with `DateTimeFormatter` allows `PutKudu` to support both current String-based
timestamps using the default format as well as String-based timestamps that
include microseconds. Unit tests for `PutKudu` illustrate the supported
behavior.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
