ChrisSamo632 commented on a change in pull request #5535:
URL: https://github.com/apache/nifi/pull/5535#discussion_r753403481
##########
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceImpl.java
##########
@@ -168,6 +186,21 @@ private void setupClient(final ConfigurationContext
context) throws MalformedURL
this.client = builder.build();
}
+ private CredentialsProvider addCredentials(CredentialsProvider
credentialsProvider, final AuthScope authScope, final String username, final
String password) {
Review comment:
The `credentialsProvider` was being (re)assigned if null, then passed
back out of the method, but I'll re-write it to use a separate method-scoped
variable for clarity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
