adam-markovics commented on a change in pull request #1107:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1107#discussion_r746477485
##########
File path: extensions/windows-event-log/tests/BookmarkTests.cpp
##########
@@ -41,7 +41,8 @@ std::unique_ptr<Bookmark> createBookmark(TestPlan &test_plan,
const utils::Identifier &uuid =
IdGenerator::getIdGenerator()->generate()) {
const auto state_manager =
test_plan.getStateManagerProvider()->getCoreComponentStateManager(uuid);
const auto logger = test_plan.getLogger();
- return std::make_unique<Bookmark>(channel, L"*", "", uuid, false,
state_manager, logger);
+ auto bookmark = std::make_unique<Bookmark>(channel, L"*", "", uuid, false,
state_manager, logger);
+ return bookmark;
Review comment:
Honestly, I don't remember. I think there were other commits where there
were operations before returning, and they weren't completely cleaned up. I
will revert and test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
