Chris Sampson created NIFI-9366:
-----------------------------------

             Summary: nifi-persistent-provenance-repository tests create 
unwanted provenance_repository directory in filesystem
                 Key: NIFI-9366
                 URL: https://issues.apache.org/jira/browse/NIFI-9366
             Project: Apache NiFi
          Issue Type: Bug
          Components: Core Framework
    Affects Versions: 1.15.0
            Reporter: Chris Sampson
            Assignee: Chris Sampson


Executing the tests within the {{nifi-persistent-provenance-repository}} 
results in an unwanted directory being created in the filesystem that could 
accidentally be committed to git:
* 
{{nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/provenance_repository/}}

This is caused by the Groovy-based test 
{{EncryptedWriteAheadProvenanceRepositoryTest#testShouldRegisterAndGetEvents}}, 
which doesn't override the default {{nifi.properties}} value for 
{{nifi.provenance.repository.directory.}} of {{provenance_repository}} - this 
results in the directory being created as indicated above. It would be better 
to locate the directory either in {{target/}} (therefore ignored by default in 
Git commits as part of the Maven build) or a Temp directory as done in 
{{#testWriteAheadProvenanceRepositoryShouldRegisterAndRetrieveEvents}} within 
the same Test class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to