fgerlits commented on pull request #1182:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1182#issuecomment-945741723
I like this. Just two comments for discussion:
1. using a `const&` {Input,Output}StreamCallback parameter, which makes the
`std::ref()` necessary, does not feel natural to me. If I was to write new
code with a stateful callback, I would not know I'd need `std::ref()`, and then
spend a fair bit of time trying to find out why my code doesn't work. I would
prefer a universal reference parameter, but I don't like having to put `read()`
etc in the header. Maybe someone has a better idea?
2. [[predictable]] I would put the stream `shared_ptr` to `&` change in a
separate pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
