simonbence commented on a change in pull request #5423:
URL: https://github.com/apache/nifi/pull/5423#discussion_r720284694



##########
File path: 
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java
##########
@@ -365,9 +388,12 @@ public void process(InputStream in) throws IOException {
                     final long millis = 
stopWatch.getDuration(TimeUnit.MILLISECONDS);
                     tempDotCopyFile = tempCopyFile;
 
-                    if (!conflictResponse.equals(APPEND_RESOLUTION)
-                            || (conflictResponse.equals(APPEND_RESOLUTION) && 
!destinationExists)) {
+                    if  (
+                        writingStrategy.equals(WRITE_AND_RENAME)
+                        && (!conflictResponse.equals(APPEND_RESOLUTION) || 
(conflictResponse.equals(APPEND_RESOLUTION) && !destinationExists))

Review comment:
       You are correct and I was playing with the idea but I did not want to 
change the existing expression and make it less readable




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to