markap14 commented on a change in pull request #5412: URL: https://github.com/apache/nifi/pull/5412#discussion_r719601610
########## File path: nifi-nar-bundles/nifi-stateless-processor-bundle/nifi-stateless-processor/src/main/java/org/apache/nifi/processors/stateless/retrieval/FileSystemDataflowRetrieval.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.processors.stateless.retrieval; + +import com.fasterxml.jackson.databind.DeserializationFeature; +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.nifi.processor.ProcessContext; +import org.apache.nifi.processors.stateless.ExecuteStateless; +import org.apache.nifi.registry.flow.VersionedFlowSnapshot; + +import java.io.IOException; +import java.io.InputStream; + +public class FileSystemDataflowRetrieval implements DataflowRetrieval { + @Override + public VersionedFlowSnapshot retrieveDataflowContents(final ProcessContext context) throws IOException { + final ObjectMapper objectMapper = new ObjectMapper(); + objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); Review comment: It's not needed in this case. It's needed for the caching case because when a dataflow is retrieved from registry, there is more information available in the dataflow snapshot wrapper element, which is not provided when we download a flow locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
