markap14 commented on a change in pull request #5412:
URL: https://github.com/apache/nifi/pull/5412#discussion_r716927743
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarClassLoaders.java
##########
@@ -140,8 +140,8 @@ public void init(final ClassLoader rootClassloader,
/**
* Should be called at most once.
*/
- private InitContext load(final ClassLoader rootClassloader,
- final File frameworkWorkingDir, final File
extensionsWorkingDir, final String frameworkNarId)
+ private InitContext load(final ClassLoader rootClassloader, final File
frameworkWorkingDir, final File extensionsWorkingDir,
+ final String frameworkNarId, final boolean
logDetails)
Review comment:
I considered changing it to something like that but felt like it was
just more confusing. If `true`, it logs at info level. That's all that'll
generally show up in logs. So for any typical deployment, `false` = do not log.
I.e., "Do you want the details showing up in typical logs or no?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
