lordgamez commented on a change in pull request #1166:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1166#discussion_r703300008
##########
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##########
@@ -163,10 +163,10 @@ TEST_CASE("Connections components are parsed from yaml",
"[YamlConfiguration]")
"flowfile expiration: \n"
"drop empty: \n"});
YamlConnectionParser yaml_connection_parser(connection_node,
"test_node", parent_ptr, logger);
- CHECK_THROWS(yaml_connection_parser.getWorkQueueSizeFromYaml());
- CHECK_THROWS(yaml_connection_parser.getWorkQueueDataSizeFromYaml());
- CHECK_THROWS(yaml_connection_parser.getFlowFileExpirationFromYaml());
- CHECK_THROWS(yaml_connection_parser.getDropEmptyFromYaml());
+ REQUIRE(0 == yaml_connection_parser.getWorkQueueSizeFromYaml());
+ REQUIRE(0 == yaml_connection_parser.getWorkQueueDataSizeFromYaml());
+ REQUIRE(0 == yaml_connection_parser.getFlowFileExpirationFromYaml());
+ REQUIRE(0 == yaml_connection_parser.getDropEmptyFromYaml());
Review comment:
Also disabled `readability/check` linter rule in
3e4ccdb98e53fbd2b49176eb3f32d86bb0cb06d0 as it suggested using CHECK_EQ instead
of CHECK, but catch2 does not have a CHECK_EQ assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
