exceptionfactory commented on a change in pull request #5332:
URL: https://github.com/apache/nifi/pull/5332#discussion_r696836175
##########
File path:
nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/util/crypto/NiFiLegacyCipherProviderGroovyTest.groovy
##########
@@ -260,9 +247,14 @@ class NiFiLegacyCipherProviderGroovyTest {
* from the password using a long digest result at the time of key length
checking.
* @throws IOException
*/
- @Ignore("Only needed once to determine max supported password lengths")
+ @Disabled("Only needed once to determine max supported password lengths")
+ @Ignore
Review comment:
Thanks @MikeThomsen! For clarification, I am not recommending enabling
currently ignored tests as part of the standard build, but to change some tests
to use the
[EnabledIfSystemProperty](https://junit.org/junit5/docs/current/api/org.junit.jupiter.api/org/junit/jupiter/api/condition/EnabledIfSystemProperty.html)
annotation. This type of test is a good example of something that should not
be run by default, but could be useful under certain conditions.
The evaluation needs to be done on a case-by-case basis, but there are a
handful of performance-related tests that could be enabled through a System
property.
For this particular test method, the `NiFiLegacyCipherProvider` class itself
is deprecated due to use of insecure algorithms, so I would support removing
this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
