adamdebreceni commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r680708207
##########
File path: main/CMakeLists.txt
##########
@@ -39,16 +39,8 @@ if(WIN32)
endif()
add_executable(minifiexe ${MINIFIEXE_SOURCES})
-if (NOT USE_SHARED_LIBS)
- if (LIBC_STATIC)
- set_target_properties(minifiexe PROPERTIES
LINK_SEARCH_START_STATIC 1)
- endif(LIBC_STATIC)
-endif(NOT USE_SHARED_LIBS)
Review comment:
LIBC_STATIC is marked as experimental, not tested in the ci, and we no
longer build a single static minifiexe, readded this as in the future we might
want to support both static and shared builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
