exceptionfactory commented on a change in pull request #5261:
URL: https://github.com/apache/nifi/pull/5261#discussion_r679440032
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardReloadComponent.java
##########
@@ -97,10 +100,19 @@ public void reload(final ProcessorNode existingNode, final
String newType, final
// need to refresh the properties in case we are changing from ghost
component to real component
existingNode.refreshProperties();
+
newNode.setProperties(getPropertiesForSetting(existingNode.getProperties()));
+
logger.debug("Triggering async validation of {} due to processor
reload", existingNode);
flowController.getValidationTrigger().trigger(existingNode);
}
+ private static Map<String, String> getPropertiesForSetting(final
Map<PropertyDescriptor, PropertyConfiguration> propertyMap) {
Review comment:
As a private method that doesn't access or class members, it seems fine
to leave it static as you described. Thanks for moving it to the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
