adamdebreceni commented on a change in pull request #1138: URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r678168130
########## File path: libminifi/include/core/extension/Extension.h ########## @@ -0,0 +1,90 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <memory> +#include <vector> +#include <string> + +#include "properties/Configure.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace core { +namespace extension { + +class Extension; + +using ExtensionConfig = std::shared_ptr<org::apache::nifi::minifi::Configure>; +using ExtensionInit = bool(*)(Extension*, const ExtensionConfig&); + +class ExtensionInitializer; + +class Extension { + friend class ExtensionInitializer; + public: + explicit Extension(std::string name, ExtensionInit init); + virtual ~Extension(); + + bool initialize(const ExtensionConfig& config) { + return init_(this, config); + } + + const std::string& getName() const { + return name_; + } + + protected: Review comment: I don't feel "them being protected" and "having a friend" conflicting, `Extension` is referenced in other places (`ExtensionManager`, `Module`) and `doInitialize` does not guarantee the same semantics `initialize` does, so it should not be part of the public interface, and is expected to be overridden by subclasses and only be called by `ExtensionInitializer`, we could probably achieve the same thing through some inheritance hierarchy although I feel like that would make it more complex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
