exceptionfactory commented on a change in pull request #5098:
URL: https://github.com/apache/nifi/pull/5098#discussion_r674471757
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureDataLakeStorage.java
##########
@@ -226,9 +239,12 @@ protected String getPath(ProcessContext context) {
options.setRecursive(recurseSubdirectories);
Pattern baseDirectoryPattern = Pattern.compile("^" + baseDirectory
+ "/?");
+ final String tempFilePrefix =
defaultIfBlank(System.getProperty("tempFilePrefix"), TEMP_FILE_PREFIX);
Review comment:
Direct calls to `System.getProperty()` should be avoided. Can you
explain the reason for getting the value of a system property?
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureDataLakeStorage.java
##########
@@ -102,6 +104,7 @@
"where the previous node left off, without duplicating the data.")
public class ListAzureDataLakeStorage extends
AbstractListProcessor<ADLSFileInfo> {
+ public static final String TEMP_FILE_PREFIX = "nifitemp_";
Review comment:
Although this variable is `public`, it does not appear to be referenced
outside of the processor, and `PutAzureDataLakeStorage` has the same value. It
seems like this value should be abstracted to a shared location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
