fgerlits commented on pull request #1017:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1017#issuecomment-862213301


   This still fails after merging #1028 and #1083.  The main problem is that 
`SingleFileContentHashValidator` reports a hash mismatch on the 2.1 GiB test 
file:
   ```
         INFO:root:Output file created: 
/tmp/.nifi-test-output.fe59da51-9bb0-4c9f-9966-876ec2ea543b/.4c3b8487-5767-4b29-830e-7e83d4e3e5ec.053203f8-ce84-11eb-82db-0242c0a81002
         INFO:root:Output folder: 
/tmp/.nifi-test-output.fe59da51-9bb0-4c9f-9966-876ec2ea543b/
         INFO:root:dir 
/tmp/.nifi-test-output.fe59da51-9bb0-4c9f-9966-876ec2ea543b/ -- name 
.4c3b8487-5767-4b29-830e-7e83d4e3e5ec.053203f8-ce84-11eb-82db-0242c0a81002
         INFO:root:expected hash: 3531295d2dc5e038e4f4e684d020167b -- actual: 
2073b6f0bc607551c97ed79b4e0de87e
   ```
   I suspect this is problem with the test and not with GetFile/PutFile, but it 
needs to be investigated.
   
   Another, minor issue is that the 20 seconds timeout needs to be increased, 
as running the test with the 2.1 GiB test file takes around 40 seconds on my 
computer.
   
   Also, `OutputEventHandler` prints "Output file modified" more than 2 million 
times, which is annoying.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to