[
https://issues.apache.org/jira/browse/NIFI-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575843#comment-15575843
]
ASF GitHub Bot commented on NIFI-2819:
--------------------------------------
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1130#discussion_r83460093
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ModifyBytes.java
---
@@ -66,13 +66,15 @@
.required(true)
.addValidator(StandardValidators.DATA_SIZE_VALIDATOR)
.defaultValue("0 B")
+ .expressionLanguageSupported(true)
.build();
public static final PropertyDescriptor END_OFFSET = new
PropertyDescriptor.Builder()
.name("End Offset")
--- End diff --
When I saw _end-offset_ i got confused since the next offset is the end
offset, but description states its _Number of bytes removed at the end of the
file_. This means it's not an offset at all.
I know this is not part of the immediate issue, but at least consider
raising an improvement JIRA where this could be fixed. Obviously we can't
change the _name_, so we'll keep it, but we can add _displayProperty(..)_
> Improve ModifyBytes (Add expression language support)
> -----------------------------------------------------
>
> Key: NIFI-2819
> URL: https://issues.apache.org/jira/browse/NIFI-2819
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.0.0
> Reporter: n h
> Assignee: Matt Burgess
> Fix For: 1.1.0
>
>
> Add expression language support to "Start Offset" and "End Offset"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
