ChrisSamo632 edited a comment on pull request #4756: URL: https://github.com/apache/nifi/pull/4756#issuecomment-854706875
> @ChrisSamo632 any reason that these methods are called `jsonEscape` and `jsonUnescape`? I think `escapeJson` and `unescapeJson` make more sense and would be more consistent with the existing conventions. For example, there already is a `Base64Decode`/`Base64Encode`, `PadLeft`/`PadRight`, etc. @markap14 I had them that way at first then changed them as `JsonEscape` seemed more in keeping with `Base64Encode` for example - first part is the data format, second the operation being performed. I'm not particularly precious either way though, so happy to go with the concensus. I note that a different pattern has been used for RecordPath as for Expression Language (where an `escapeJson` already exists along with `escapeHtml`, `escapeXml`, etc.) - that's why I went with `escapeJson` here originally but then changed it because of the `base64Encode` style already in RecordPath -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
