nabmoh123 commented on pull request #4939:
URL: https://github.com/apache/nifi/pull/4939#issuecomment-814001461


   > Thanks for this improvement. Could you add a customValidate method to 
check the configuration of the processor and make it invalid if both brokers 
and host properties are set simultaneously, or if none of the properties are 
set? You may find similar pieces of code in other processors.
   > 
   > Right now, one could leave all properties empty, the processor would be 
valid and throw NPE exceptions since the `connection` object would not be set.
   
   The Host and Port have default values set. So NiFi reenters the default 
values in if you leave the properties empty. Is it still worth adding in the 
customValidate for this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to