[
https://issues.apache.org/jira/browse/NIFI-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15555844#comment-15555844
]
ASF GitHub Bot commented on NIFI-1526:
--------------------------------------
Github user mathiastiberghien commented on the issue:
https://github.com/apache/nifi/pull/1107
I'll correct styles (I'm really newbie to java and open source).
I add issues to launch the styles tests so I hope I won't miss anything.
Sorry for the undesired change. I had to put a hard code reference because
the generated path failed (too long?). I made a mistake reverting code and
I'll fix it
Le 7 oct. 2016 19:49, "Pierre Villard" <[email protected]> a écrit :
> *@pvillard31* requested changes on this pull request.
>
> Hi @mathiastiberghien <https://github.com/mathiastiberghien>, thanks for
> the additional work!
>
> Still some checkstyle issues:
>
> [WARNING]
src/main/java/org/apache/nifi/controller/FlowController.java[1066:13] (blocks)
LeftCurly: '{' should be on the previous line.
> [WARNING]
src/test/java/org/apache/nifi/controller/TestFlowController.java[50] (imports)
AvoidStarImport: Using the '.*' form of import should be avoided -
org.apache.nifi.processor.*.
>
> Besides, could you remove the use of '_' in classes name and variables
> name. This is not very Java stylish :) (unless some specific cases such as
> final static variables). Also in your annotations, could you avoid
starting
> methods name with a capital letter?
>
> I agree all of this could be checked through our checkstyle configuration
> (and I'll have a look at this) but I make those remarks to ensure some
> consistency in the code.
>
> Otherwise thanks for the unit tests!
> ------------------------------
>
> In nifi-nar-bundles/nifi-framework-bundle/nifi-
> framework/nifi-framework-core/src/test/java/org/apache/nifi/
> controller/TestFlowController.java
> <https://github.com/apache/nifi/pull/1107#pullrequestreview-3347394>:
>
> > @@ -71,7 +74,7 @@
>
> @Before
> public void setup() {
> - System.setProperty(NiFiProperties.PROPERTIES_FILE_PATH,
TestFlowController.class.getResource("/nifi.properties").getFile());
> + System.setProperty(NiFiProperties.PROPERTIES_FILE_PATH,
FlowController.class.getResource("/nifi.properties").getFile());
>
> Is it really needed?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/nifi/pull/1107#pullrequestreview-3347394>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AVbS_EmmADM4wUPPLfGZUpHkaTKcpoAGks5qxoYhgaJpZM4KO_Hp>
> .
>
> Allow components to provide default values for Yield Duration and Run Schedule
> ------------------------------------------------------------------------------
>
> Key: NIFI-1526
> URL: https://issues.apache.org/jira/browse/NIFI-1526
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Bryan Bende
> Priority: Minor
>
> It would be nice for developers of processors (and maybe reporting tasks and
> controller services) to be able to specify a default value for Yield duration
> and Run Schedule.
> Currently Yield defaults to 1 second and Run Schedule defaults to 0 seconds.
> There may be cases where these are not the best default values and the
> developer wants to start off with better defaults, still allowing the user to
> tune as needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
