arpadboda commented on a change in pull request #1008:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1008#discussion_r579045658
##########
File path: win_build_vs.bat
##########
@@ -28,6 +28,7 @@ set build_coap=OFF
set build_jni=OFF
set build_SQL=OFF
set build_AWS=OFF
+set build_SFTP=OFF
Review comment:
Two reasons I didn't do:
1) Tests require Maven and Java, so they wouldn't run with current instance
configs
2) Win builds sometimes already reach timeout, didn't want to add further
stuff, especially longer tests like this. (can take minutes to start up the
java sftp mock server)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
