szaszm commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577651674
##########
File path: extensions/librdkafka/ConsumeKafka.h
##########
@@ -124,6 +124,17 @@ class ConsumeKafka : public core::Processor {
// Initialize, overwrite by NiFi RetryFlowFile
void initialize() override;
+ class WriteCallback : public OutputStreamCallback {
Review comment:
Does it need to be public? It's only used inside the class IIRC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
