exceptionfactory commented on a change in pull request #4079:
URL: https://github.com/apache/nifi/pull/4079#discussion_r576387004



##########
File path: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi.sh
##########
@@ -245,6 +245,11 @@ SERVICEDESCRIPTOR
         ln -s "/etc/init.d/${SVC_NAME}" "/etc/rc2.d/K65${SVC_NAME}" || { echo 
"Could not create link /etc/rc2.d/K65${SVC_NAME}"; exit 1; }
         echo "Service ${SVC_NAME} installed"
     fi
+
+    # systemd: generate nifi.service from init.d
+    if [ "$(pidof systemd)" ]; then

Review comment:
       That's a good question.  It would be helpful to know how likely that 
scenario is to occur, but if systemd is not being used for initialization, then 
running `systemctl daemon-reload` shouldn't have an impact on the 
initialization configuration.  Ultimately, it would be better to handle service 
installation for systemd using an actual service configuration as opposed to 
relying on backward compatibility, but as it stands, this update seems like a 
good step forward.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to