adamdebreceni commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r560993751
##########
File path: libminifi/src/core/logging/LoggerConfiguration.cpp
##########
@@ -85,6 +108,7 @@ LoggerConfiguration::LoggerConfiguration()
void LoggerConfiguration::initialize(const std::shared_ptr<LoggerProperties>
&logger_properties) {
std::lock_guard<std::mutex> lock(mutex);
root_namespace_ = initialize_namespaces(logger_properties);
+ initializeCompression(lock, logger_properties);
Review comment:
note that the maximum size of the in-memory logs (cached and compressed)
is configurable, would like the whole compression to be configurable as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
