szaszm commented on a change in pull request #967:
URL: https://github.com/apache/nifi-minifi-cpp/pull/967#discussion_r555105117
##########
File path: extensions/windows-event-log/CollectorInitiatedSubscription.cpp
##########
@@ -647,7 +647,10 @@ int CollectorInitiatedSubscription::processQueue(const
std::shared_ptr<core::Pro
while (renderedXMLs_.try_dequeue(xml)) {
auto flowFile = session->create();
- session->write(flowFile, &WriteCallback(xml));
+ {
+ WriteCallback wc{ xml };
Review comment:
The old version took the address of an rvalue, which is an MSVC
extension, and I had compilation issues with it. It might have been because of
my attempt to compile with `/std:c++latest`, but I figured fixing noncompliant
code is a good thing anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
