hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553348682
##########
File path: libminifi/include/core/FlowFile.h
##########
@@ -134,7 +135,9 @@ class FlowFile : public CoreComponent, public
ReferenceContainer {
* @param value value to set
* @return result of finding key
*/
- bool getAttribute(std::string key, std::string& value) const;
+ bool getAttribute(const std::string& key, std::string& value) const;
+
+ utils::optional<std::reference_wrapper<const std::string>>
getAttribute(const std::string& key) const;
Review comment:
Good observation, this was cherry-picked from #911 hoping that it would
be merged much much earlier than this PR, whereas it is still open. I think I
will just close that PR and move the change here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
