exceptionfactory commented on a change in pull request #4737:
URL: https://github.com/apache/nifi/pull/4737#discussion_r552897870



##########
File path: 
nifi-nar-bundles/nifi-standard-services/nifi-ssl-context-service-api/src/main/java/org/apache/nifi/ssl/SSLContextService.java
##########
@@ -56,26 +56,36 @@
     }
 
     /**
-     * Returns a configured {@link SSLContext} from the populated 
configuration values. This method is preferred
-     * over the overloaded method which accepts the deprecated {@link 
ClientAuth} enum.
+     * Create and initialize {@link SSLContext} using configured properties. 
This method is preferred over deprecated
+     * create methods due to not requiring a client authentication policy.
+     *
+     * @return {@link SSLContext} initialized using configured properties
+     */
+    SSLContext createContext();
+
+    /**
+     * Returns a configured {@link SSLContext} from the populated 
configuration values. This method is deprecated
+     * due to {@link org.apache.nifi.security.util.ClientAuth} not being 
applicable or used when initializing the
+     * {@link SSLContext}
      *
      * @param clientAuth the desired level of client authentication
      * @return the configured SSLContext
      * @throws ProcessException if there is a problem configuring the context
      */
-    SSLContext createSSLContext(final org.apache.nifi.security.util.ClientAuth 
clientAuth) throws ProcessException;
+    @Deprecated
+    SSLContext createSSLContext(org.apache.nifi.security.util.ClientAuth 
clientAuth) throws ProcessException;
 
     /**
      * Returns a configured {@link SSLContext} from the populated 
configuration values. This method is deprecated

Review comment:
       Added




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to