markap14 commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-754196454
Thanks for the pull request @NissimShiman! I think this is a helpful feature. Looking at the PR, the code looks good. I think the UI needs a bit of tweaking, though. This results in the text boxes now being more narrow so that they can't even hold a UUID without an ellipsis. And I think we need to use a different heading than "NOT" to indicate that a field should be inverted. Also, while this adds a "Fields" and "NOT" column header that is in the same font as the "Start Date" text, etc. it feels a bit off to use that styling for the newly added column headers. But my UI/UX skills are nil :) So while I can tell you that I think it needs some tweaking, I won't be great at suggesting exactly how it should be tweaked. So I'm hoping that @moranr can hopefully provide a suggestion or two to ensure that the UI provides a consistent look/feel with the application as a whole. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
