NissimShiman commented on pull request #4620: URL: https://github.com/apache/nifi/pull/4620#issuecomment-746644194
Code is well structured and unit tested. I compiled and tested on both java 8 and java 11 and issue is fixed. Issue was that transitUri in SEND ProvenanceEvent can be incorrect when PutFTP/PutSFTP's hostname property is set to an expression. It used to evaluate the first flowfile that went through for the hostname's expression and then use that value for all future flowfiles' transitUri for their SEND events. Now the transitUri always reflects the correct hostname value for the associated flowfile. Nice job @tlsmith109! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
